Restructure testacc execution #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burythehammer
approved these changes
Apr 15, 2025
Collaborator
burythehammer
left a comment
burythehammer
left a comment
There was a problem hiding this comment.
Couple of small things, but approved nonetheless
|
|
||
| func TestAccResourceRedisCloudSubscriptionPeering_aws(t *testing.T) { | ||
|
|
||
| testAccRequiresEnvVar(t, "EXECUTE_TESTS") |
Collaborator
There was a problem hiding this comment.
having now gone through a few of these, it feels like we could extract out these magic strings to some constants just incase you mistype something.
Collaborator
Author
There was a problem hiding this comment.
Yes, agreed and I will address this in the next PR.
burythehammer
pushed a commit
that referenced
this pull request
Nov 10, 2025
* Separates out each group of Acceptance tests into their own steps * Disbales TestAccResourceRedisCloudCloudAccount_basic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with the existing execution of the Acceptance tests is the length of time and understanding the context of failures. Viewing the output of the failure is also problematic due to the volume of information returned.
The following PR separates out the Acceptance Tests into grouped individual steps in the workflow. These are
Each step allows the execution time to be understood and will execute 6 Acceptance Tests in parallel.
Steps that fail can be re-run if there is an unexpected situation such as network comms or timeout.